Skip to content

Minor refactor, fix issues with package.json, output types correctly #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nicholas-ochoa wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor refactor, fix issues with package.json, output types correctly #13

nicholas-ochoa wants to merge 2 commits into from

Conversation

@nicholas-ochoa
Copy link

@nicholas-ochoa nicholas-ochoa commented Aug 20, 2025 •
edited
Loading

Addresses #12

  • Fixed issues with package.json
  • Enabled declarations and added types to package.json
  • Output bindings to binding.cjs / binding.d.ts instead of index.cjs / index.d.ts
  • Rename indax.ts to index.ts
  • Move napi build step to just before tsc compilation to ensure binding.d.ts exists
  • Removed file manipulation steps in build.sh that were breaking things

I've submitted and signed a CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicholas-ochoa